[ekg2-commit] ekg2: commands.c (HEAD) [peres]

CVS commit cvs w toxygen.net
Wto, 1 Maj 2007, 18:11:55 CEST


Module name:	ekg2
Changes by:	peres	2007-05-01 18:11:53

Modified files:
	commands.c

Log message:
Comments.

Index: commands.c
===================================================================
RCS file: /home/cvs/ekg2/ekg/commands.c,v
diff -d -u -r1.272 -r1.273
--- commands.c	28 Apr 2007 17:07:36 -0000	1.272
+++ commands.c	1 May 2007 16:11:53 -0000	1.273
@@ -598,11 +598,14 @@
 	return 0;
 }
 
+/**
+ * cmd_exec_info_t is internal structure, containing information about processes started using /exec.
+ */
 typedef struct {
-	char *target;		/* jeśli wysyłamy wynik, to do kogo? */
-	char *session;		/* jaka sesja? */
-	int quiet;		/* czy mamy być cicho? */
-	string_t buf;	/* jeśli buforujemy, to tutaj */
+	char *target;		/**< Target UID, if redirecting output to someone */
+	char *session;		/**< Session UID */
+	int quiet;		/**< Whether to be quiet (i.e. don't print info on exit) */
+	string_t buf;		/**< Buffer */
 } cmd_exec_info_t;
 
 static WATCHER_LINE(cmd_exec_watch_handler)	/* stały */
@@ -704,7 +707,10 @@
 			exit(1);
 		}
 #else
-/* XXX, fork and execute cmd /C $command */
+/* XXX, fork and execute cmd /C $command
+ * MG: I think using explicitly 'cmd /c' is very bad - in win9x we've got command.com instead;
+ *     but AFAIR $COMSPEC should be always defined; if not, we should even use command.com
+ *     (AFAIK newer versions of windows are backwards compatible with this) */
 		pid = -1;
 #endif
 


Więcej informacji o liście dyskusyjnej ekg2-commit