[ekg2-commit] ekg2: commands.c (HEAD) [darkjames]

Pią, 4 Maj 2007, 11:41:49 CEST

Module name:	ekg2
Changes by:	darkjames	2007-05-04 11:41:47

Modified files:
	commands.c

Log message:
again.

Index: commands.c
===================================================================
RCS file: /home/cvs/ekg2/plugins/jabber/commands.c,v
diff -d -u -r1.167 -r1.168

--- commands.c	4 May 2007 09:38:40 -0000	1.167
+++ commands.c	4 May 2007 09:41:47 -0000	1.168
@@ -588,13 +588,13 @@
 					enum XML_Error errc = XML_GetErrorCode(p);
 					const char *errs;
 
-					if (errc && (errs = XML_ErrorString(errc))) {
+					if (errc && (errs = XML_ErrorString(errc)))
 						print("jabber_msg_xmlsyntaxerr", errs);
-						XML_ParserFree(p);
-						xfree(fullmsg);
-						return -1;
-					}
-					/* we never should get here */
+					else	print("jabber_msg_xmlsyntaxerr", "unknown");
+
+					XML_ParserFree(p);
+					xfree(fullmsg);
+					return -1;			/* XXX, return -1; here is invalid, we already sent data to server */
 				}
 				XML_ParserFree(p);
 				watch_write(j->send_watch, "%s", fullmsg); /* to avoid problems with %-formats */
@@ -622,7 +622,7 @@
 			secure = 1;
 			xfree(e_msg);
 		}
-	} 
+	}
 	if (!secure) 
 		watch_write(j->send_watch, "<body>%s</body>", msg);
 
