From z w xatka.net Wed Jun 10 13:06:01 2009 From: z w xatka.net (=?iso-8859-2?Q?Pawe=B3?= Zuzelski) Date: Wed, 10 Jun 2009 13:06:01 +0200 Subject: [ekg2-devel] [PATCH] komenda /kick w xmpp muc Message-ID: <20090610110601.GA11132@davabel.touk.pl> Witam, załączony patch (względem aktualnego trunk) naprawia obsługę komendy /kick w xmpp muc. -- Pozdrawiam, Paweł Zuzelski -------------- następna część --------- Index: plugins/jabber/commands.c =================================================================== --- plugins/jabber/commands.c (wersja 4826) +++ plugins/jabber/commands.c (kopia robocza) @@ -2034,6 +2034,8 @@ const char *jid = params[1]; char *reason; + char *action; + char *ident; if (!(id = jabber_iq_reg(session, "mucadmin_", c->name+5, "query", "http://jabber.org/protocol/muc#admin"))) { printq("generic_error", "Error in getting id for ban, check debug window. Lucky guy."); @@ -2044,12 +2046,23 @@ reason = jabber_escape(params[2]); + if (!xstrcmp(name, "ban")) { + action="affiliation=\"outcast\""; + ident="jid"; + } else if (!xstrcmp(name, "unban")) { + action="affiliation=\"none\""; + ident="jid"; + } else if (!xstrcmp(name, "kick")) { + action="role=\"none\""; + ident="nick"; + } else { + printq("generic_error", "Unimplemented command"); + } + watch_write(j->send_watch, "" - "%s" - "", id, c->name+5, - !xstrcmp(name, "ban") ? /* ban */ "outcast" : /* unban+kick */ "none", - jid, reason ? reason : ""); + "%s" + "", id, c->name+5, action, ident, jid, reason ? reason : ""); xfree(reason); } return 0; From darkjames w darkjames.ath.cx Wed Jun 10 13:33:19 2009 From: darkjames w darkjames.ath.cx (Jakub Zawadzki) Date: Wed, 10 Jun 2009 13:33:19 +0200 Subject: [ekg2-devel] [PATCH] komenda /kick w xmpp muc In-Reply-To: <20090610110601.GA11132@davabel.touk.pl> References: <20090610110601.GA11132@davabel.touk.pl> Message-ID: <20090610113319.GA29517@darkjames.ath.cx> On Wed, Jun 10, 2009 at 01:06:01PM +0200, Paweł Zuzelski wrote: > załączony patch (względem aktualnego trunk) naprawia obsługę komendy > /kick w xmpp muc. Commitnałem w r4837, dzięki. From darkjames w darkjames.ath.cx Wed Jun 10 13:34:42 2009 From: darkjames w darkjames.ath.cx (Jakub Zawadzki) Date: Wed, 10 Jun 2009 13:34:42 +0200 Subject: [ekg2-devel] [PATCH] komenda /kick w xmpp muc In-Reply-To: <20090610113319.GA29517@darkjames.ath.cx> References: <20090610110601.GA11132@davabel.touk.pl> <20090610113319.GA29517@darkjames.ath.cx> Message-ID: <20090610113442.GA29735@darkjames.ath.cx> On Wed, Jun 10, 2009 at 01:33:19PM +0200, Jakub Zawadzki wrote: > On Wed, Jun 10, 2009 at 01:06:01PM +0200, Paweł Zuzelski wrote: > > załączony patch (względem aktualnego trunk) naprawia obsługę komendy > > /kick w xmpp muc. > > Commitnałem w r4837, dzięki. Albo w r4827... From z w xatka.net Wed Jun 10 13:37:48 2009 From: z w xatka.net (=?iso-8859-2?Q?Pawe=B3?= Zuzelski) Date: Wed, 10 Jun 2009 13:37:48 +0200 Subject: [ekg2-devel] [PATCH] komenda /kick w xmpp muc In-Reply-To: <20090610113442.GA29735@darkjames.ath.cx> References: <20090610110601.GA11132@davabel.touk.pl> <20090610113319.GA29517@darkjames.ath.cx> <20090610113442.GA29735@darkjames.ath.cx> Message-ID: <20090610113748.GB11132@davabel.touk.pl> On Wed, 10 Jun 2009, Jakub Zawadzki wrote: > On Wed, Jun 10, 2009 at 01:33:19PM +0200, Jakub Zawadzki wrote: > > On Wed, Jun 10, 2009 at 01:06:01PM +0200, Paweł Zuzelski wrote: > > > załączony patch (względem aktualnego trunk) naprawia obsługę komendy > > > /kick w xmpp muc. > > > > Commitnałem w r4837, dzięki. > > Albo w r4827... Spoko, widzę w commit-logu. Dzięki. -- Pozdrawiam, Paweł Zuzelski From trac w wafel.com Sun Jun 14 18:53:59 2009 From: trac w wafel.com (ekg2) Date: Sun, 14 Jun 2009 16:53:59 -0000 Subject: [ekg2-devel] [ekg2] #22: unable to authenticate with some jabber servers In-Reply-To: <036.3e12ed574ad9c6dea63c37a4316782fe@wafel.com> References: <036.3e12ed574ad9c6dea63c37a4316782fe@wafel.com> Message-ID: <045.9a9890e43fff00965e69bb7ca078fb62@wafel.com> #22: unable to authenticate with some jabber servers ----------------------------------------------+----------------------------- Reporter: porridge | Owner: team Type: runtime problem | Status: new Priority: major | Component: jabber Version: SVN | Resolution: Keywords: jabber authentication user domain | ----------------------------------------------+----------------------------- Comment (by porridge): Replying to [comment:4 darkjames]: > Hi, > > Sending user w domain doesn't work with my jabber server (jabber.org), > so I think the best approach is to make this behaviour configurable. :-/ > Have you got any patch? :) No, and I have stopped using that server so I'm afraid I won't be able to provide a tested one. -- Ticket URL: ekg2 ekg2: internet multicommunicator From trac w wafel.com Sun Jun 14 19:07:08 2009 From: trac w wafel.com (ekg2) Date: Sun, 14 Jun 2009 17:07:08 -0000 Subject: [ekg2-devel] [ekg2] #22: unable to authenticate with some jabber servers In-Reply-To: <036.3e12ed574ad9c6dea63c37a4316782fe@wafel.com> References: <036.3e12ed574ad9c6dea63c37a4316782fe@wafel.com> Message-ID: <045.ebe2cb0dbed7496fc9e83c73eb4db5d7@wafel.com> #22: unable to authenticate with some jabber servers ----------------------------------------------+----------------------------- Reporter: porridge | Owner: team Type: runtime problem | Status: closed Priority: major | Component: jabber Version: SVN | Resolution: worksforme Keywords: jabber authentication user domain | ----------------------------------------------+----------------------------- Changes (by darkjames): * status: new => closed * resolution: => worksforme Comment: Closing, please reopen when you hit again this bug :) -- Ticket URL: ekg2 ekg2: internet multicommunicator From z w xatka.net Fri Jun 19 16:45:30 2009 From: z w xatka.net (=?iso-8859-2?Q?Pawe=B3?= Zuzelski) Date: Fri, 19 Jun 2009 16:45:30 +0200 Subject: [ekg2-devel] =?iso-8859-2?q?=5BPATCH_0/2=5D_muc_-_komendy_zwi=B1z?= =?iso-8859-2?q?ane_z_affiliation_i_role?= Message-ID: <20090619144530.GA6493@davabel.touk.pl> Witam, W patchu robię porządek z funkcjami związanymi z affiliation i role oraz implementuję brakujące komendy służące do zarządzania role użytkowników. Dotychczas komendy związane z affiliation i role były implementowane w funkcji jabber_muc_command_ban. To wprowadzało trochę zamieszania, ponieważ affiliation i role to są dwa ortogonalne względem siebie skale uprawnień użytkownika. Rozdzieliłem zatem funkcję jabber_muc_command_ban na dwie funkcje: jabber_muc_command_role i jabber_muc_command_affiliation. Funkcja jabber_muc_command_role implementuje komendy: /xmpp:kick - unset users role (remove him from channel) /xmpp:voice - set Participant role (allow him to spead at moderated channels) /xmpp:op - set Moderator role /xmpp:deop - set Visitor role /xmpp:devoice - alias for /xmpp:deop command Funkjcja jabber_muc_command_affiliation implementuje komendy: /xmpp:ban - set Outcast affiliation /xmpp:unban - unset affiliation Wciąż brakuje komend implementujących ustawianie następujących stanów: Owner affiliation Admin affiliation Member affiliation Nie wiem tylko jak powinny się nazywać odpowiednie komendy. Tutaj skończyły się ircowe analogie. Na ile udało byłem w stanie przetestować wszystkie zaimplementowane funkcje działają. Nie wiem tylko dlaczego nick wykopany z kanału nie znika z listy nicków w pływającym okienku. Prawdopodobnie moduł nie potrafi zinterpretować odpowiedniej odpowiedzi serwera (albo mój serwer wysyła nieprawidłowe presence(?)). -- Pozdrawiam, Paweł Zuzelski From z w xatka.net Fri Jun 19 16:49:12 2009 From: z w xatka.net (=?iso-8859-2?Q?Pawe=B3?= Zuzelski) Date: Fri, 19 Jun 2009 16:49:12 +0200 Subject: [ekg2-devel] =?iso-8859-2?q?=5BPATCH_1/2=5D_muc_-_komendy_zwi=B1z?= =?iso-8859-2?q?ane_z_affiliation_i=09role?= In-Reply-To: <20090619144530.GA6493@davabel.touk.pl> References: <20090619144530.GA6493@davabel.touk.pl> Message-ID: <20090619144912.GB6493@davabel.touk.pl> Implementacje komend związanych z affiliation i role. -- Paweł Zuzelski -------------- następna część --------- Index: plugins/jabber/commands.c =================================================================== --- plugins/jabber/commands.c (wersja 4827) +++ plugins/jabber/commands.c (kopia robocza) @@ -2008,16 +2008,82 @@ return 0; } -static COMMAND(jabber_muc_command_ban) { /* %0 [target] %1 [jid] %2 [reason] */ +/* This function handles commands related to user roles: + * /xmpp:kick - unset users role (remove him from channel) + * /xmpp:voice - set Participant role (allow him to spead at moderated channels) + * /xmpp:op - set Moderator role + * /xmpp:deop - set Visitor role + * /xmpp:devoice - alias for /xmpp:deop command + * + * TODO: + * - allow to specify user by jid, not only by nick + * - check if user is no the muc channel + */ +static COMMAND(jabber_muc_command_role) { /* %0 [target] %1 [jid] %2 [reason] */ jabber_private_t *j = session_private_get(session); newconference_t *c; if (!(c = newconference_find(session, target))) { - printq("generic_error", "/xmpp:ban && /xmpp:kick && /xmpp:unban only valid in MUC"); + printq("generic_error", "/xmpp:kick && /xmpp:op && /xmpp:deop && /xmpp:voice && /xmpp:devoice only valid in MUC"); return -1; } -/* XXX, make check if command = "kick" than check if user is on the muc channel... cause we can make /unban */ + const char *nick = params[1]; + + const char *role; + const char *id; + char *reason; + + if (!xstrcmp(name, "op")) { + role = "moderator"; + } else if (!xstrcmp(name, "voice")) { + role = "participant"; + } else if (!xstrcmp(name, "deop")) { + role = "visitor"; + } else if (!xstrcmp(name, "devoice")) { + role = "visitor"; + } else if (!xstrcmp(name, "kick")) { + role = "none"; + } else { + printq("generic_error", "Unimplemented command"); + return -1; + } + + if (!(id = jabber_iq_reg(session, "mucadmin_", c->name+5, "query", "http://jabber.org/protocol/muc#admin"))) { + printq("generic_error", "Error in getting id for ban, check debug window. Lucky guy."); + return 1; + } + + reason = jabber_escape(params[2]); + watch_write(j->send_watch, + "" + "%s" + "", id, c->name+5, role, nick, reason ? reason : ""); + xfree(reason); + + return 0; +} + +/* This function handles commands related to affiliation: + * /xmpp:ban - set Outcast affiliation + * /xmpp:unban - unset affiliation + * + * TODO: + * - What commands should do following: + * + set Owner affiliation + * + set Admin affiliation + * + set Member affiliation + * - Implement these commands + */ +static COMMAND(jabber_muc_command_affiliation) { /* %0 [target] %1 [jid] %2 [reason] */ + jabber_private_t *j = session_private_get(session); + newconference_t *c; + + if (!(c = newconference_find(session, target))) { + printq("generic_error", "/xmpp:ban && /xmpp:unban only valid in MUC"); + return -1; + } + if (!params[1]) { const char *id; @@ -2032,19 +2098,14 @@ } else { const char *jid = params[1]; - const char *action, *ident; + const char *affiliation; const char *id; char *reason; if (!xstrcmp(name, "ban")) { - ident = "jid"; - action = "affiliation=\"outcast\""; + affiliation = "outcast"; } else if (!xstrcmp(name, "unban")) { - ident = "jid"; - action = "affiliation=\"none\""; - } else if (!xstrcmp(name, "kick")) { - ident = "nick"; - action = "role=\"none\""; + affiliation = "none"; } else { printq("generic_error", "Unimplemented command"); return -1; @@ -2061,8 +2122,8 @@ reason = jabber_escape(params[2]); watch_write(j->send_watch, "" - "%s" - "", id, c->name+5, action, ident, jid, reason ? reason : ""); + "%s" + "", id, c->name+5, affiliation, jid, reason ? reason : ""); xfree(reason); } return 0; @@ -2322,7 +2383,7 @@ "-a --accept -d --deny -r --request -c --cancel"); command_add(&jabber_plugin, "xmpp:away", "r", jabber_command_away, JABBER_ONLY, NULL); command_add(&jabber_plugin, "xmpp:back", "r", jabber_command_away, JABBER_ONLY, NULL); - command_add(&jabber_plugin, "xmpp:ban", "! ? ?", jabber_muc_command_ban, JABBER_FLAGS_TARGET, NULL); + command_add(&jabber_plugin, "xmpp:ban", "! ? ?", jabber_muc_command_affiliation, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:bookmark", "!p ?", jabber_command_private, JABBER_FLAGS_REQ, "-a --add -c --clear -d --display -m --modify -r --remove"); command_add(&jabber_plugin, "xmpp:config", "!p", jabber_command_private, JABBER_FLAGS_REQ, @@ -2333,17 +2394,20 @@ command_add(&jabber_plugin, "xmpp:connect", NULL, jabber_command_connect, JABBER_ONLY, NULL); command_add(&jabber_plugin, "xmpp:conversations", NULL, jabber_command_conversations, JABBER_FLAGS, NULL); command_add(&jabber_plugin, "xmpp:del", "!u", jabber_command_del, JABBER_FLAGS_TARGET, NULL); + command_add(&jabber_plugin, "xmpp:deop", "! !", jabber_muc_command_role, JABBER_FLAGS_TARGET, NULL); + command_add(&jabber_plugin, "xmpp:devoice", "! !", jabber_muc_command_role, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:disconnect", "r", jabber_command_disconnect, JABBER_ONLY, NULL); command_add(&jabber_plugin, "xmpp:dnd", "r", jabber_command_away, JABBER_ONLY, NULL); command_add(&jabber_plugin, "xmpp:ffc", "r", jabber_command_away, JABBER_ONLY, NULL); command_add(&jabber_plugin, "xmpp:find", "?", jabber_command_find, JABBER_FLAGS, NULL); command_add(&jabber_plugin, "xmpp:invisible", "r", jabber_command_away, JABBER_ONLY, NULL); command_add(&jabber_plugin, "xmpp:join", "! ? ?", jabber_muc_command_join, JABBER_FLAGS_TARGET, NULL); - command_add(&jabber_plugin, "xmpp:kick", "! ! ?", jabber_muc_command_ban, JABBER_FLAGS_TARGET, NULL); + command_add(&jabber_plugin, "xmpp:kick", "! ! ?", jabber_muc_command_role, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:lastseen", "!u", jabber_command_lastseen, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:modify", "!Uu ?", jabber_command_modify,JABBER_FLAGS_REQ, "-n --nickname -g --group"); command_add(&jabber_plugin, "xmpp:msg", "!uU !", jabber_command_msg, JABBER_FLAGS_MSG, NULL); + command_add(&jabber_plugin, "xmpp:op", "! !", jabber_muc_command_role, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:part", "! ?", jabber_muc_command_part, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:passwd", "?", jabber_command_passwd, JABBER_FLAGS, NULL); command_add(&jabber_plugin, "xmpp:privacy", "? ? ?", jabber_command_privacy, JABBER_FLAGS, NULL); @@ -2357,13 +2421,14 @@ command_add(&jabber_plugin, "xmpp:topic", "? ?", jabber_muc_command_topic, JABBER_FLAGS_REQ, NULL); command_add(&jabber_plugin, "xmpp:transpinfo", "? ?", jabber_command_transpinfo, JABBER_FLAGS, NULL); command_add(&jabber_plugin, "xmpp:transports", "? ?", jabber_command_transports, JABBER_FLAGS, NULL); - command_add(&jabber_plugin, "xmpp:unban", "! ?", jabber_muc_command_ban, JABBER_FLAGS_TARGET, NULL); + command_add(&jabber_plugin, "xmpp:unban", "! ?", jabber_muc_command_affiliation, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:unregister", "?", jabber_command_register, JABBER_FLAGS, NULL); command_add(&jabber_plugin, "xmpp:userinfo", "!u", jabber_command_userinfo, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:userlist", "! ?", jabber_command_userlist, JABBER_FLAGS_REQ, "-g --get -p --put"); /* BFW: it is unlike GG, -g gets userlist from file, -p writes it into it */ command_add(&jabber_plugin, "xmpp:vacation", "?", jabber_command_vacation, JABBER_FLAGS, NULL); command_add(&jabber_plugin, "xmpp:ver", "!u", jabber_command_ver, JABBER_FLAGS_TARGET, NULL); /* ??? ?? ? ?@?!#??#!@? */ + command_add(&jabber_plugin, "xmpp:voice", "! !", jabber_muc_command_role, JABBER_FLAGS_TARGET, NULL); command_add(&jabber_plugin, "xmpp:xa", "r", jabber_command_away, JABBER_ONLY, NULL); command_add(&jabber_plugin, "xmpp:xml", "!", jabber_command_xml, JABBER_ONLY, NULL); From z w xatka.net Fri Jun 19 16:50:09 2009 From: z w xatka.net (=?iso-8859-2?Q?Pawe=B3?= Zuzelski) Date: Fri, 19 Jun 2009 16:50:09 +0200 Subject: [ekg2-devel] =?iso-8859-2?q?=5BPATCH_2/2=5D_muc_-_komendy_zwi=B1z?= =?iso-8859-2?q?ane_z_affiliation_i=09role?= In-Reply-To: <20090619144530.GA6493@davabel.touk.pl> References: <20090619144530.GA6493@davabel.touk.pl> Message-ID: <20090619145009.GC6493@davabel.touk.pl> Opisy komend związanych z affiliation i role. -- Paweł Zuzelski -------------- następna część --------- Index: plugins/jabber/commands-pl.txt =================================================================== --- plugins/jabber/commands-pl.txt (wersja 4827) +++ plugins/jabber/commands-pl.txt (kopia robocza) @@ -49,6 +49,13 @@ Je?eli nie podano opisu to b?ie szukany losowy opis. Podanie ,,%T-%n'' zamiast powodu spowoduje wyczyszczenie opisu. +ban + parametry: [JID] + krotki opis: banuje JID z kana?u lub wy?wietla list?an? + Je?eli nie podano JID wy?wietla list?banowanych uzytkownik?+ W przeciwnym wypadku banuje dany JID z okre?lonego kana?u. + bookmark parametry: krotki opis: zarzadzanie zakladkami serwer-side (jabber:iq:private) @@ -114,6 +121,20 @@ parametry: [nazwa] krotki opis: usuwa z naszego rostera +deop + parametry: [kana?] [nick] + krotki opis: degraduje nick do roli go?cia + + Odbiera u?ytkownikowi prawa moderatora kana?u oraz prawo wysy?ania + wiadomo?ci je?eli kana? jest moderowany. + +devoice + parametry: [kana?] [nick] + krotki opis: degraduje nick do roli go?cia + + Odbiera u?ytkownikowi prawa moderatora kana?u oraz prawo wysy?ania + wiadomo?ci je?eli kana? jest moderowany. + disconnect parametry: [opis/-] krotki opis: roz??cza si?d serwera @@ -135,6 +156,10 @@ Je?eli nie podano opisu to b?ie szukany losowy opis. Podanie ,,%T-%n'' zamiast powodu spowoduje wyczyszczenie opisu. +kick + parametry: [kana?] [nick] + krotki opis: wyrzuca nick z kana?u + invisible parametry: [opis/-] krotki opis: zmienia stan na zaj? @@ -162,6 +187,10 @@ -n, --nickname wpis w li?cie kontakt? +op + parametry: [kana?] [nick] + krotki opis: nadaje nickowi uprawnienia moderatora + passwd parametry: krotki opis: zmienia has?o @@ -231,6 +260,13 @@ parametry: [konferencja] krotki opis: ustawia topic MUC +unban + parametry: [kana?] [JID] + krotki opis: zdejmuje ban na dany JID z kana?u + + Je?eli nie podano JID wy?wietla list?banowanych uzytkownik?+ W przeciwnym wypadku usuwa ban danego JID z okre?lonego kana?u. + userinfo parametry: krotki opis: pobiera informacje z katalogu Jabbera o danym jid @@ -239,6 +275,16 @@ parametry: krotki opis: pobiera informacj? sytemie operacyjnym i wersji klienta Jabbera danego jid +voice + parametry: [kana?] [nick] + krotki opis: daje "g?os" nickowi + + Nadaje u?ytkownikowi uprawnienia do m?nia na kanale nawet je?li + kana? jest moderowany. + + Uwaga: ustawienie voice na uzytkowniku b?cym moderatorem spowoduje + odebraniu mu praw administratora. + xa parametry: [opis/-] krotki opis: zmienia stan na bardzo zaj? Index: plugins/jabber/commands-en.txt =================================================================== --- plugins/jabber/commands-en.txt (wersja 4827) +++ plugins/jabber/commands-en.txt (kopia robocza) @@ -49,6 +49,13 @@ If description wasn't given, random description will be looked for. Giving ,,%T-%n'' instead of description will clear description. +ban + parameters: [channel] + short description: Bans the specified JID from the given channel + + If no JID is specified, command lists all jids banned from given + channel. Otherwise it bans specified JID from the given channel. + change parameters: short description: changes data in vcard @@ -82,6 +89,20 @@ parameters: [name] short description: removes user from roster +deop + parameters: [channel] [nick] + short description: take all privileges off from the nick + + Take voice and moderator privilages off from the gicen nick on the + given channel. + +devoice + parameters: [channel] [nick] + short description: take all privileges off from the nick + + Take voice and moderator privilages off from the gicen nick on the + given channel. + disconnect parameters: [description/-] short description: roz??cza si?d serwera @@ -110,6 +131,10 @@ If description wasn't given, random description will be looked for. Giving ,,%T-%n'' instead of description will clear description. +kick + parameters: + short description: kick nick off the channel + lastseen parameters: short description: retrieves information on last logout time for given jid @@ -130,6 +155,10 @@ -n, --nickname contact nickname +op + parameters: + short description: Gives moderator privileges to the specified nick + passwd parameters: short description: changes password @@ -156,6 +185,10 @@ parameters: [uid] short description: set MUC topic +unban + parameters: [channel] [JID] + short description: unban given JID from the muc channel + userinfo parameters: short description: retrieves Jabber Directory info about given jid @@ -181,6 +214,13 @@ parameters: short description: retrieves information about OS and client of given jid +voice + parameters: + short description: give the voice to the nick + + Voice allows to speak on moderated channel. Note that if you give + voice to operator, you will take off moderator privileges from him. + xa parameters: [description/-] short description: changes to status ,,extended away'' From darkjames w darkjames.ath.cx Fri Jun 19 18:09:49 2009 From: darkjames w darkjames.ath.cx (Jakub Zawadzki) Date: Fri, 19 Jun 2009 18:09:49 +0200 Subject: [ekg2-devel] =?iso-8859-2?q?=5BPATCH_0/2=5D_muc_-_komendy_zwi=B1z?= =?iso-8859-2?q?ane_z_affiliation_i=09role?= In-Reply-To: <20090619144530.GA6493@davabel.touk.pl> References: <20090619144530.GA6493@davabel.touk.pl> Message-ID: <20090619160949.GA7465@darkjames.ath.cx> On Fri, Jun 19, 2009 at 04:45:30PM +0200, Paweł Zuzelski wrote: > W patchu robię porządek z funkcjami związanymi z affiliation i role > oraz implementuję brakujące komendy służące do zarządzania role > użytkowników. commitnałem całość (wraz z dokumentacją i drobnymi poprawkami) w r4828, dzięki. > Na ile udało byłem w stanie przetestować wszystkie zaimplementowane > funkcje działają. Nie wiem tylko dlaczego nick wykopany z kanału nie > znika z listy nicków w pływającym okienku. commitnałem poprawkę w r4829, powinno teraz być dobrze. From z w xatka.net Fri Jun 19 22:21:35 2009 From: z w xatka.net (=?iso-8859-2?Q?Pawe=B3?= Zuzelski) Date: Fri, 19 Jun 2009 22:21:35 +0200 Subject: [ekg2-devel] =?iso-8859-2?q?=5BPATCH_0/2=5D_muc_-_komendy_zwi=B1z?= =?iso-8859-2?q?ane_z_affiliation=09i=3Frole?= In-Reply-To: <20090619160949.GA7465@darkjames.ath.cx> References: <20090619144530.GA6493@davabel.touk.pl> <20090619160949.GA7465@darkjames.ath.cx> Message-ID: <20090619202135.GA5480@davabel> On Fri, 19 Jun 2009, Jakub Zawadzki wrote: > On Fri, Jun 19, 2009 at 04:45:30PM +0200, Paweł Zuzelski wrote: > > W patchu robię porządek z funkcjami związanymi z affiliation i role > > oraz implementuję brakujące komendy służące do zarządzania role > > użytkowników. > > commitnałem całość (wraz z dokumentacją i drobnymi poprawkami) w r4828, dzięki. dzięki. Teraz jak przeglądam jeszcze tą dokumentację, to widzę, że chyba nieprawidłowo zrobiłem opisy komend: Co dokładnie oznaczają nawiasy i [parametr]? <> to są obowiązkowe parametry a [] to opcjonalne? -- Pozdrawiam, Paweł Zuzelski From darkjames w darkjames.ath.cx Fri Jun 19 22:35:19 2009 From: darkjames w darkjames.ath.cx (Jakub Zawadzki) Date: Fri, 19 Jun 2009 22:35:19 +0200 Subject: [ekg2-devel] =?iso-8859-2?q?=5BPATCH_0/2=5D_muc_-_komendy_zwi=B1z?= =?iso-8859-2?q?ane_z=09affiliation=3Fi=3Frole?= In-Reply-To: <20090619202135.GA5480@davabel> References: <20090619144530.GA6493@davabel.touk.pl> <20090619160949.GA7465@darkjames.ath.cx> <20090619202135.GA5480@davabel> Message-ID: <20090619203519.GA23406@darkjames.ath.cx> On Fri, Jun 19, 2009 at 10:21:35PM +0200, Paweł Zuzelski wrote: > Teraz jak przeglądam jeszcze tą dokumentację, to widzę, że chyba > nieprawidłowo zrobiłem opisy komend: Co dokładnie oznaczają nawiasy > i [parametr]? > <> to są obowiązkowe parametry a [] to opcjonalne? Tak.